Skip to content

ledger: refactor maxPaysetHint -> avarageEncodedTxnSizeHint #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 2 commits into from
Oct 29, 2021
Merged

ledger: refactor maxPaysetHint -> avarageEncodedTxnSizeHint #3162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a974bf
refactor maxPaysetHint -> avarageEncodedTxnSizeHint
tsachiherman Oct 29, 2021
76225ef
fix typo
tsachiherman Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ledger/internal/eval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ type LedgerForCowBase interface {
// ErrRoundZero is self-explanatory
var ErrRoundZero = errors.New("cannot start evaluator for round 0")

// maxPaysetHint makes sure that we don't allocate too much memory up front
// in the block evaluator, since there cannot reasonably be more than this
// many transactions in a block.
const maxPaysetHint = 20000
// averageEncodedTxnSizeHint is an estimation for the encoded transaction size
// which is used for preallocating memory upfront in the payset. Preallocating
// helps to avoid re-allocating storage during the evaluation/validation which
// is considerably slower.
const averageEncodedTxnSizeHint = 150

// asyncAccountLoadingThreadCount controls how many go routines would be used
// to load the account data before the Eval() start processing individual
Expand Down Expand Up @@ -481,6 +482,7 @@ func StartEvaluator(l LedgerForEvaluator, hdr bookkeeping.BlockHeader, evalOpts
// Preallocate space for the payset so that we don't have to
// dynamically grow a slice (if evaluating a whole block).
if evalOpts.PaysetHint > 0 {
maxPaysetHint := evalOpts.MaxTxnBytesPerBlock / averageEncodedTxnSizeHint
if evalOpts.PaysetHint > maxPaysetHint {
evalOpts.PaysetHint = maxPaysetHint
}
Expand Down