ledger: refactor maxPaysetHint -> avarageEncodedTxnSizeHint #3162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3162 +/- ##
==========================================
- Coverage 43.80% 43.80% -0.01%
==========================================
Files 391 391
Lines 86880 86881 +1
==========================================
- Hits 38062 38058 -4
- Misses 42786 42790 +4
- Partials 6032 6033 +1 ☔ View full report in Codecov by Sentry. |
algobarb
reviewed
Oct 29, 2021
algobarb
approved these changes
Oct 29, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Nov 3, 2021
…#3162) ## Summary This refactoring would eliminate the need to change the maxPaysetHint while we modify the block size. ## Test Plan Use existing tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactoring would eliminate the need to change the maxPaysetHint while we modify the block size.
Test Plan
Use existing tests.