Use math.bits intrinsics to simplify addw/mulw opcodes #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2839 +/- ##
==========================================
- Coverage 47.28% 47.24% -0.04%
==========================================
Files 351 351
Lines 56381 56359 -22
==========================================
- Hits 26659 26629 -30
- Misses 26730 26736 +6
- Partials 2992 2994 +2
Continue to review full report at Codecov.
|
algorandskiy
reviewed
Sep 4, 2021
Removes some code, but more importantly speeds up mulw considerably. We have always charged 1 unit of cost for mulw, but it was actually more expensive. This fixes that. A nice side-effect is that opPlus/opAddw and opMul/opMulw are simplified and easier to follow. Benchmarks confirm nothing is slower (and mulw is ~5 times faster). All tests of opAddwImpl and opMulwImpl have been retained by conducting the same test with actual teal, instead of directly testing those (now non-existent) functions.
algorandskiy
approved these changes
Sep 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes some code, but more importantly speeds up mulw considerably.
We have always charged 1 unit of cost for mulw, but it was actually
more expensive. This fixes that.
A nice side-effect is that opPlus/opAddw and opMul/opMulw are
simplified and easier to follow. Benchmarks confirm nothing is
slower (and mulw is ~5 times faster).
Test Plan
All tests of opAddwImpl and opMulwImpl have been retained by
conducting the same test with actual teal, instead of directly testing
those (now non-existent) functions.