Application transactions (#2661)

Allow AVM 1.0 programs to "execute transactions"

1. An app now has authority over an account which is the hash of its appid.
2. The app can create transactions with three new opcodes, tx_begin, tx_field, and tx_submit.
3. If the transaction so created would need to be authorized by that app account from 1, the effects occur.
4. Fees on inner transactions are paid from the app account, though overpaying at the top-level can be pooled.

So far, only pay and axfer are allowed. acfg and afrz are under consideration, but have separate issues written.

This makes ApplyData a recursive datastructure, so that the "inner" transactions of app calls can be encoded in EvalDelta and, themselves, have ApplyData.

Author: jannotti

cmd/opdoc/tmLanguage.go

@@ -172,10 +172,11 @@ func buildSyntaxHighlight() *tmLanguage {
 				Name:  "keyword.other.unit.teal",
 				Match: fmt.Sprintf("^(%s)\\b", strings.Join(names, "|")),
 			})
-		// For these four, accumulate into allArithmetics,
+		// For these, accumulate into allArithmetics,
 		// and only add to keyword.Patterns later, when all
 		// have been collected.
-		case "Arithmetic", "Byte Array Slicing", "Byteslice Arithmetic", "Byteslice Logic":
+		case "Arithmetic", "Byte Array Slicing", "Byte Array Arithmetic",
+			"Byte Array Logic", "Inner Transactions":
 			escape := map[rune]bool{
 				'*': true,
 				'+': true,

config/consensus.go

@@ -283,6 +283,9 @@ type ConsensusParams struct {
 	// maximum sum of the lengths of the key and value of one app state entry
 	MaxAppSumKeyValueLens int
 
+	// maximum number of inner transactions that can be created by an app call
+	MaxInnerTransactions int
+
 	// maximum number of applications a single account can create and store
 	// AppParams for at once
 	MaxAppsCreated int
@@ -431,6 +434,9 @@ var MaxStateDeltaKeys int
 // any version, used only for decoding purposes. Never decrease this value.
 var MaxLogCalls int
 
+// MaxInnerTransactions is the maximum number of inner transactions that may be created in an app call.
+var MaxInnerTransactions int
+
 // MaxLogicSigMaxSize is the largest logical signature appear in any of the supported
 // protocols, used for decoding purposes.
 var MaxLogicSigMaxSize int
@@ -494,6 +500,7 @@ func checkSetAllocBounds(p ConsensusParams) {
 	// There is no consensus parameter for MaxLogCalls and MaxAppProgramLen as an approximation
 	// Its value is much larger than any possible reasonable MaxLogCalls value in future
 	checkSetMax(p.MaxAppProgramLen, &MaxLogCalls)
+	checkSetMax(p.MaxInnerTransactions, &MaxInnerTransactions)
 }
 
 // SaveConfigurableConsensus saves the configurable protocols file to the provided data directory.
@@ -1015,6 +1022,7 @@ func initConsensusProtocols() {
 
 	// Enable App calls to pool budget in grouped transactions
 	vFuture.EnableAppCostPooling = true
+	vFuture.MaxInnerTransactions = 16
 
 	// Allow 50 app opt ins
 	vFuture.MaxAppsOptedIn = 50

daemon/algod/api/algod.oas2.json

@@ -811,7 +811,10 @@
         ],
         "responses": {
           "200": {
-            "$ref": "#/responses/PendingTransactionResponse"
+            "description": "Given a transaction id of a recently submitted transaction, it returns information about it.  There are several cases when this might succeed:\n- transaction committed (committed round \u003e 0)\n- transaction still in the pool (committed round = 0, pool error = \"\")\n- transaction removed from pool due to error (committed round = 0, pool error != \"\")\n\nOr the transaction may have happened sufficiently long ago that the node no longer remembers it, and this will return an error.",
+            "schema": {
+              "$ref": "#/definitions/PendingTransactionResponse"
+            }
           },
           "400": {
             "description": "Bad Request",
@@ -1748,7 +1751,7 @@
         "logs": {
           "type": "array",
           "items": {
-            "$ref": "#/definitions/LogItem"
+            "type": "string"
           }
         },
         "cost": {
@@ -1921,21 +1924,79 @@
         }
       }
     },
-    "LogItem": {
-      "description": "Application Log",
+    "PendingTransactionResponse": {
+      "description": "Details about a pending transaction. If the transaction was recently confirmed, includes confirmation details like the round and reward details.",
       "type": "object",
       "required": [
-        "id",
-        "value"
+        "txn",
+        "pool-error"
       ],
       "properties": {
-        "id": {
-          "description": "unique application identifier",
+        "asset-index": {
+          "description": "The asset index if the transaction was found and it created an asset.",
+          "type": "integer"
+          },
+        "application-index": {
+          "description": "The application index if the transaction was found and it created an application.",
           "type": "integer"
         },
-        "value": {
-          "description": " base64 encoded log message",
+        "close-rewards": {
+          "description": "Rewards in microalgos applied to the close remainder to account.",
+          "type": "integer"
+        },
+        "closing-amount": {
+          "description": "Closing amount for the transaction.",
+          "type": "integer"
+        },
+        "asset-closing-amount": {
+          "description": "The number of the asset's unit that were transferred to the close-to address.",
+          "type": "integer"
+        },
+        "confirmed-round": {
+          "description": "The round where this transaction was confirmed, if present.",
+          "type": "integer"
+        },
+        "pool-error": {
+          "description": "Indicates that the transaction was kicked out of this node's transaction pool (and specifies why that happened).  An empty string indicates the transaction wasn't kicked out of this node's txpool due to an error.\n",
           "type": "string"
+        },
+        "receiver-rewards": {
+          "description": "Rewards in microalgos applied to the receiver account.",
+          "type": "integer"
+        },
+        "sender-rewards": {
+          "description": "Rewards in microalgos applied to the sender account.",
+          "type": "integer"
+        },
+        "local-state-delta": {
+          "description": "\\[ld\\] Local state key/value changes for the application being executed by this transaction.",
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/AccountStateDelta"
+          }
+        },
+        "global-state-delta": {
+          "description": "\\[gd\\] Global state key/value changes for the application being executed by this transaction.",
+          "$ref": "#/definitions/StateDelta"
+        },
+        "logs": {
+          "description": "\\[lg\\] Logs for the application being executed by this transaction.",
+          "type": "array",
+          "items": {
+            "type": "string"
+          }
+        },
+        "inner-txns": {
+          "description": "Inner transactions produced by application execution.",
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/PendingTransactionResponse"
+          }
+        },
+        "txn": {
+          "description": "The raw signed transaction.",
+            "type": "object",
+          "x-algorand-format": "SignedTransaction"
         }
       }
     }
@@ -2278,78 +2339,6 @@
         }
       }
     },
-    "PendingTransactionResponse": {
-      "description": "Given a transaction id of a recently submitted transaction, it returns information about it.  There are several cases when this might succeed:\n- transaction committed (committed round \u003e 0)\n- transaction still in the pool (committed round = 0, pool error = \"\")\n- transaction removed from pool due to error (committed round = 0, pool error != \"\")\n\nOr the transaction may have happened sufficiently long ago that the node no longer remembers it, and this will return an error.",
-      "schema": {
-        "description": "Details about a pending transaction. If the transaction was recently confirmed, includes confirmation details like the round and reward details.",
-        "type": "object",
-        "required": [
-          "txn",
-          "pool-error"
-        ],
-        "properties": {
-          "asset-index": {
-            "description": "The asset index if the transaction was found and it created an asset.",
-            "type": "integer"
-          },
-          "application-index": {
-            "description": "The application index if the transaction was found and it created an application.",
-            "type": "integer"
-          },
-          "close-rewards": {
-            "description": "Rewards in microalgos applied to the close remainder to account.",
-            "type": "integer"
-          },
-          "closing-amount": {
-            "description": "Closing amount for the transaction.",
-            "type": "integer"
-          },
-          "asset-closing-amount": {
-            "description": "The number of the asset's unit that were transferred to the close-to address.",
-            "type": "integer"
-          },
-          "confirmed-round": {
-            "description": "The round where this transaction was confirmed, if present.",
-            "type": "integer"
-          },
-          "pool-error": {
-            "description": "Indicates that the transaction was kicked out of this node's transaction pool (and specifies why that happened).  An empty string indicates the transaction wasn't kicked out of this node's txpool due to an error.\n",
-            "type": "string"
-          },
-          "receiver-rewards": {
-            "description": "Rewards in microalgos applied to the receiver account.",
-            "type": "integer"
-          },
-          "sender-rewards": {
-            "description": "Rewards in microalgos applied to the sender account.",
-            "type": "integer"
-          },
-          "local-state-delta": {
-            "description": "\\[ld\\] Local state key/value changes for the application being executed by this transaction.",
-            "type": "array",
-            "items": {
-              "$ref": "#/definitions/AccountStateDelta"
-            }
-          },
-          "global-state-delta": {
-            "description": "\\[gd\\] Global state key/value changes for the application being executed by this transaction.",
-            "$ref": "#/definitions/StateDelta"
-          },
-          "logs": {
-            "description": "\\[lg\\] Logs for the application being executed by this transaction.",
-            "type": "array",
-            "items": {
-              "$ref": "#/definitions/LogItem"
-            }
-          },
-          "txn": {
-            "description": "The raw signed transaction.",
-            "type": "object",
-            "x-algorand-format": "SignedTransaction"
-          }
-        }
-      }
-    },
     "PendingTransactionsResponse": {
       "description": "A potentially truncated list of transactions currently in the node's transaction pool. You can compute whether or not the list is truncated if the number of elements in the **top-transactions** array is fewer than **total-transactions**.",
       "schema": {