Skip to content

Conversation

@jasonpaulos
Copy link
Contributor

Summary

This is a follow up to #2661. It adds the app account address to the goal app info command, and it changes the log item type format in the REST API to "byte" in order to show that it's binary data. As a bonus, the encoder will automatically convert to base64 for us.

Test Plan

Added a unit test to verify the encoder converts logs to base64.

@jasonpaulos jasonpaulos changed the title Display app address to goal app info & show logs are binary in REST API Display app address in goal app info & show logs are binary in REST API Sep 3, 2021
@jasonpaulos jasonpaulos requested a review from jannotti September 3, 2021 21:02
@jasonpaulos jasonpaulos self-assigned this Sep 3, 2021
jannotti
jannotti previously approved these changes Sep 3, 2021
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig the auto base64.

Linter is mad about partitiontest.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #2836 (3d91527) into master (e32b2c2) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
- Coverage   47.28%   47.26%   -0.02%     
==========================================
  Files         351      351              
  Lines       56381    56382       +1     
==========================================
- Hits        26659    26651       -8     
- Misses      26730    26737       +7     
- Partials     2992     2994       +2     
Impacted Files Coverage Δ
cmd/goal/application.go 12.77% <0.00%> (-0.03%) ⬇️
daemon/algod/api/server/v2/handlers.go 0.00% <ø> (ø)
daemon/algod/api/server/v2/utils.go 14.72% <0.00%> (ø)
daemon/algod/api/server/v2/dryrun.go 61.79% <100.00%> (ø)
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/service.go 69.35% <0.00%> (-0.78%) ⬇️
network/wsPeer.go 74.37% <0.00%> (ø)
ledger/acctupdates.go 62.63% <0.00%> (+0.08%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32b2c2...3d91527. Read the comment docs.

@jannotti jannotti merged commit 418b101 into algorand:master Sep 7, 2021
@jasonpaulos jasonpaulos deleted the app-actions-followup branch September 7, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants