Skip to content

Conversation

@tsachiherman
Copy link
Contributor

Summary

update crypto library to use partitiontest

Test Plan

These are tests.

@tsachiherman tsachiherman requested a review from id-ms August 9, 2021 19:59
@tsachiherman tsachiherman self-assigned this Aug 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #2721 (82758ab) into master (e46f02a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
- Coverage   47.14%   47.12%   -0.02%     
==========================================
  Files         350      350              
  Lines       55954    55954              
==========================================
- Hits        26379    26371       -8     
- Misses      26626    26633       +7     
- Partials     2949     2950       +1     
Impacted Files Coverage Δ
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
catchup/service.go 69.35% <0.00%> (-0.78%) ⬇️
network/requestTracker.go 71.12% <0.00%> (-0.44%) ⬇️
network/wsNetwork.go 60.73% <0.00%> (-0.19%) ⬇️
network/wsPeer.go 74.37% <0.00%> (ø)
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46f02a...82758ab. Read the comment docs.

Copy link
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tsachiherman tsachiherman merged commit fb3f9a9 into algorand:master Aug 10, 2021
@tsachiherman tsachiherman deleted the tsachi/partcrypto branch August 10, 2021 10:29
@tsachiherman tsachiherman restored the tsachi/partcrypto branch August 16, 2021 15:21
tmc pushed a commit to tmc/go-algorand that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants