using the appIdx instead of txn app id (#2720)

barnjamin · web-flow · commit e46f02aea723 · 2021-08-09T15:42:43.000-04:00
Passing a foreign app id to the `goal app create` cmd with dryrun tries to use ApplicationId (0) instead of the foreign app id.
diff --git a/libgoal/libgoal.go b/libgoal/libgoal.go
@@ -1035,7 +1035,7 @@ func MakeDryrunStateGenerated(client Client, txnOrStxn interface{}, other []tran
 				} else {
 					// otherwise need to fetch app state
 					var app generatedV2.Application
-					if app, err = client.ApplicationInformation(uint64(tx.ApplicationID)); err != nil {
+					if app, err = client.ApplicationInformation(uint64(appIdx)); err != nil {
 						return
 					}
 					appParams = app.Params

Original file line number	Diff line number	Diff line change
`@@ -1035,7 +1035,7 @@ func MakeDryrunStateGenerated(client Client, txnOrStxn interface{}, other []tran`
`1035`	`1035`	`} else {`
`1036`	`1036`	`// otherwise need to fetch app state`
`1037`	`1037`	`var app generatedV2.Application`
`1038`		`- if app, err = client.ApplicationInformation(uint64(tx.ApplicationID)); err != nil {`
	`1038`	`+ if app, err = client.ApplicationInformation(uint64(appIdx)); err != nil {`
`1039`	`1039`	`return`
`1040`	`1040`	`}`
`1041`	`1041`	`appParams = app.Params`