Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594
Mitigation for #5477 in the meantime.

Changes included:

Add facets parameter as a potential value for run endpoint as it is allowed in the payload

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team as a code owner October 16, 2025 13:44
@ClaraMuller ClaraMuller requested review from a team, millotp and shortcuts October 16, 2025 13:44
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 16, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by ca792e5e411441b06ae5e447e1c7bb29b88da2da
🍃 Generated commit 54fdb4997d84df83c412d650c5eb8095cc9601de
🌲 Generated branch generated/clara/feat/specs/facet-available-in-run-endpoint
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1739
javascript 1655
php 1433
csharp 1265
python 1135
java 1028
swift 832
ruby 749
scala 23

@ClaraMuller
Copy link
Contributor Author

Hello @millotp as a mitigation of #5477, I created this PR, but even without re-defining anything, I have some issues.

@shortcuts
Copy link
Member

shortcuts commented Oct 16, 2025

this one is expected @ClaraMuller you need to add IndexSettingsFacets to https://github.com/algolia/api-clients-automation/blob/main/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java#L32, swift have one big bundle that prevents duplicate names between its sub packages (search, composition)

@ClaraMuller
Copy link
Contributor Author

Thanks @shortcuts I am not confortable modifying this, can I get your help on this ?

@millotp
Copy link
Collaborator

millotp commented Oct 16, 2025

Hey @ClaraMuller, actually it was the same name clashing issue as the last PR, I did some renaming and now there is no conflicts for facets anymore, is this what you expected to generate ?

@ClaraMuller
Copy link
Contributor Author

@millotp it seems that @shortcuts was suggesting an other solution

@millotp
Copy link
Collaborator

millotp commented Oct 16, 2025

it seems that @shortcuts was suggesting an other solution

I spoke with @shortcuts, it wouldn't have worked, the issue was with redocly, not openapi-generator, so we need to fix the spec before changing the generator

@ClaraMuller
Copy link
Contributor Author

Oh I see in that case if does generate a proper parameter called facets (which is my goal here) let's do it that way.

aiordache
aiordache previously approved these changes Oct 17, 2025
@millotp
Copy link
Collaborator

millotp commented Oct 20, 2025

I couldn't make it work without breaking algoliasearch lite or recommend, so the name of the model will have to stay as IndexSettingsFacets to avoid other clashes

@ClaraMuller
Copy link
Contributor Author

Hello @millotp
What can Comp API do ? At the moment change is minimal I am a bit at the limit of what I can contribute autnomously.

@sfaiqh
Copy link

sfaiqh commented Oct 20, 2025

@millotp @shortcuts is this issue introduced by this PR or has become apparent due to it? Would it be possible to see the duplicated files where they are?

Any help would be appreciated as this change is required for customer testing which we have to do soon.

@millotp millotp force-pushed the clara/feat/specs/facet-available-in-run-endpoint branch from fee1b9c to 39b7328 Compare October 22, 2025 08:21
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of it @millotp

@millotp millotp enabled auto-merge (squash) October 22, 2025 08:47
@millotp millotp merged commit 7287faa into main Oct 22, 2025
29 checks passed
@millotp millotp deleted the clara/feat/specs/facet-available-in-run-endpoint branch October 22, 2025 09:01
algolia-bot added a commit that referenced this pull request Oct 22, 2025
… (generated) [skip ci]

Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 22, 2025
…rated)

algolia/api-clients-automation#5486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants