Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594

Changes included:

  • Enrich the documentation for facets query parameter with features that are only implemented within Composition API.
    For that, remove the link toward Search API doc and create a facets section within Composition API query parameter.
  • Add this parameter as a potential value for run endpont as it is allowed in the payload

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team October 14, 2025 19:29
@ClaraMuller ClaraMuller requested a review from a team as a code owner October 14, 2025 19:29
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 14, 2025

✔️ Code generated!

Name Link
🪓 Triggered by c9f0494f1f9a5c3c045ee66563c8b83be0ab3379
🍃 Generated commit 1133a8dc4d66c3235e8a60477a03eb29e2f15fea
🌲 Generated branch generated/clara/feat/doc-for-disjunctive-faceting
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1740
javascript 1661
php 1481
csharp 1349
python 1178
java 1038
ruby 849
swift 502
scala 23

@ClaraMuller ClaraMuller force-pushed the clara/feat/doc-for-disjunctive-faceting branch 2 times, most recently from c2c73e5 to c854cef Compare October 14, 2025 19:35
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a tricky one !

@ClaraMuller ClaraMuller marked this pull request as draft October 17, 2025 12:23
@ClaraMuller ClaraMuller force-pushed the clara/feat/doc-for-disjunctive-faceting branch 3 times, most recently from 8064b45 to 36a0a10 Compare October 27, 2025 15:51
@ClaraMuller ClaraMuller force-pushed the clara/feat/doc-for-disjunctive-faceting branch from 36a0a10 to dbb02c5 Compare October 27, 2025 15:54
@ClaraMuller ClaraMuller marked this pull request as ready for review October 27, 2025 15:55
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this !

@millotp millotp merged commit 38ae444 into main Oct 27, 2025
29 checks passed
@millotp millotp deleted the clara/feat/doc-for-disjunctive-faceting branch October 27, 2025 18:51
algolia-bot added a commit that referenced this pull request Oct 27, 2025
…in Composition API (#5477) (generated) [skip ci]

Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 27, 2025
…in Composition API (generated)

algolia/api-clients-automation#5477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants