Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Fix #106 Convert facet value to string #119

Merged
merged 1 commit into from
Jun 24, 2015
Merged

Fix #106 Convert facet value to string #119

merged 1 commit into from
Jun 24, 2015

Conversation

bobylito
Copy link
Contributor

Use case :

  • user input a number as a facet filter
  • algolia returns string for facet values
  • user can't loop over the values to check if they are refined because on one side the value is a string, and on the other the value is a number, making the comparison false.

In this fix, the lib will always convert any input value for the filters to strings. This will apply to conjunctive, disjunctive and exclude refinements.

@bobylito
Copy link
Contributor Author

@Nagriar this should be of interest to you ;)

bobylito added a commit that referenced this pull request Jun 24, 2015
Fix #106 Convert facet value to string
@bobylito bobylito merged commit d8fb238 into develop Jun 24, 2015
@bobylito bobylito deleted the fix/106 branch June 24, 2015 10:50
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant