Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Always convert facet value to string in addRefinement #106

Closed
Nagriar opened this issue Jun 12, 2015 · 2 comments
Closed

Always convert facet value to string in addRefinement #106

Nagriar opened this issue Jun 12, 2015 · 2 comments
Assignees
@bobylito
Labels
Type: Bug
Milestone
2.1.2

Comments

@Nagriar
Copy link
Member

Nagriar commented Jun 12, 2015

If you add a refinement with a integer value, you won't be able to know if the value is refined in the on('result') because the response returns a string value.
@bobylito bobylito added this to the 2.1.2 milestone Jun 23, 2015
@bobylito bobylito self-assigned this Jun 24, 2015
@Nagriar
Copy link
Member Author

Nagriar commented Jun 24, 2015

👍

@bobylito
Copy link
Contributor

Thanks @Nagriar

bobylito added a commit that referenced this issue Jun 24, 2015
@bobylito
Merge pull request #119 from algolia/fix/106
d8fb238 
Fix #106 Convert facet value to string
bobylito pushed a commit that referenced this issue Jun 29, 2015
2.1.2 - 2015-06-26
7a30e14 
  * FIX : #113 support for attributes hightlightPreTag and hightlighPostTag
  * FIX : #112 distinct = undefined sent to the server
  * FIX : #110 helper.hasRefinements() now checks for numerics
  * FIX : #106 convert refinements to string
  * DOC : Update theme + fix (github.com/algolia/minami)
  * DOC : Fix misc links and descrition and added samples of objects
  * DOC : Added a cheat sheet in the generated documentation
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
Fix algolia/algoliasearch-helper-js#106 Convert facet value to string
930c33f
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
@bobylito
Merge pull request algolia/algoliasearch-helper-js#119 from algolia/f…
a9f2d15 
…ix/106

Fix algolia/algoliasearch-helper-js#106 Convert facet value to string
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
2.1.2 - 2015-06-26
5488827 
  * FIX : algolia/algoliasearch-helper-js#113 support for attributes hightlightPreTag and hightlighPostTag
  * FIX : algolia/algoliasearch-helper-js#112 distinct = undefined sent to the server
  * FIX : algolia/algoliasearch-helper-js#110 helper.hasRefinements() now checks for numerics
  * FIX : algolia/algoliasearch-helper-js#106 convert refinements to string
  * DOC : Update theme + fix (github.com/algolia/minami)
  * DOC : Fix misc links and descrition and added samples of objects
  * DOC : Added a cheat sheet in the generated documentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobylito bobylito

Labels
Type: Bug
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
2 participants
@bobylito @Nagriar