Describe actual behavior of scoped copy operation #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
changed the title
greg0ire
changed the title
greg0ire
force-pushed
the
fix_inacurrate_comment
branch
from
77a3569 to
9107196
Compare
The comments imply that records will be copied if you specify a scope. This is not the behavior I observe, and this is also not what is documented on https://www.algolia.com/doc/rest-api/search/#copymove-index : > Keep in mind that when you use the scopes parameter, you will no longer be copying records (objects) but only the specified scopes. It might have been true in the past, but it is currently not the case.
|
Hi @greg0ire ! Thanks for your contribution. I'll relauch travis and then merge it. If you have some time, I have worked on a new major version of this package and I would love to hear what you think of it! I wrote about it here: https://discourse.algolia.com/t/introducing-php-api-client-v2/5635/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
some comments
Why it was changed
The comments imply that records will be copied if you specify a scope.
This is not the behavior I observe, and this is also not what is
documented on https://www.algolia.com/doc/rest-api/search/#copymove-index :
It might have been true in the past, but it is currently not the case.