Skip to content

Commit

Permalink
Describe actual behavior of scoped copy operation
Browse files Browse the repository at this point in the history
The comments imply that records will be copied if you specify a scope.
This is not the behavior I observe, and this is also not what is
documented on https://www.algolia.com/doc/rest-api/search/#copymove-index :

> Keep in mind that when you use the scopes parameter, you will no
longer be copying records (objects) but only the specified scopes.

It might have been true in the past, but it is currently not the case.
  • Loading branch information
greg0ire committed Jul 23, 2018
1 parent 8519bf1 commit 9107196
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/AlgoliaSearch/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ public function copyIndex($srcIndexName, $dstIndexName)
}

/**
* Copy an existing index and define what to copy along with records:
* Copy an existing index and define what to copy instead of records:
* - settings
* - synonyms
* - query rules
Expand All @@ -413,7 +413,7 @@ public function copyIndex($srcIndexName, $dstIndexName)
*
* @param string $srcIndexName the name of index to copy.
* @param string $dstIndexName the new index name that will contains a copy of srcIndexName (destination will be overwritten if it already exist).
* @param array $scope Resource to copy along with records: 'settings', 'rules', 'synonyms'
* @param array $scope Resource to copy instead of records: 'settings', 'rules', 'synonyms'
* @param array $requestHeaders
* @return mixed
*/
Expand Down

0 comments on commit 9107196

Please sign in to comment.