-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: garbage collector CLI command #269
Draft
odesenfans
wants to merge
4
commits into
aleph-im:dev
Choose a base branch
from
odesenfans:od-cli-gc
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
odesenfans
force-pushed
the
od-cli-gc
branch
5 times, most recently
from
October 3, 2022 18:18
ae6eea7
to
f01adfc
Compare
Problem: if an invalid message somehow managed to reach the pending message collection, the message would be retried indefinitely logging exceptions on each run. Solution: drop invalid messages.
We now provide a CLI tool that integrates all the operations commonly performed by node operators. Currently, this CLI allows to: * generate private keys for the node, replacing a functionality that was implemented in the CCN main app directly. * run migrations, replacing the config updater script.
Added a new command to the CCN operator CLI to run a garbage collector on local storage. The new `gc run` command lists all the files that are not linked to any message or permanent pin and deletes them. Using the --verbose option, the command will print more details on the files it will preserve and delete. The --dry-run option allows to run the GC without actually deleting any file.
odesenfans
changed the title
[Storage] Garbage collector CLI
Feature: garbage collector CLI command
Oct 4, 2022
odesenfans
force-pushed
the
dev
branch
2 times, most recently
from
March 21, 2023 13:43
d9f920c
to
3d016e0
Compare
odesenfans
force-pushed
the
dev
branch
2 times, most recently
from
October 27, 2023 17:03
48b3f90
to
11bf24a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: nodes may store files that are not required anymore,
for example if the user did not confirm the storage of the file
through a message.
Solution: added a new command to the CCN operator CLI to run
a garbage collector on local storage. The new
gc run
commandlists all the files that are not linked to any message or permanent
pin and deletes them.
Using the --verbose option, the command will print more details
on the files it will preserve and delete. The --dry-run option
allows to run the GC without actually deleting any file.