Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: garbage collector CLI command #269

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

odesenfans
Copy link
Contributor

@odesenfans odesenfans commented May 15, 2022

Problem: nodes may store files that are not required anymore,
for example if the user did not confirm the storage of the file
through a message.

Solution: added a new command to the CCN operator CLI to run
a garbage collector on local storage. The new gc run command
lists all the files that are not linked to any message or permanent
pin and deletes them.

Using the --verbose option, the command will print more details
on the files it will preserve and delete. The --dry-run option
allows to run the GC without actually deleting any file.

@odesenfans
Copy link
Contributor Author

Depends on #268. Replaces #250.

Problem: web wallets do not allow signing raw messages. Instead,
they require binary payloads in a specific format.

Solution: support Micheline-style signatures, i.e. signatures
supported by wallets like Beacon.

Users can now use Micheline or raw signatures by specifying
the `signature.signingType` field to "micheline" or "raw".
By default, "raw" is assumed.

Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
@odesenfans odesenfans force-pushed the od-cli-gc branch 5 times, most recently from ae6eea7 to f01adfc Compare October 3, 2022 18:18
Problem: if an invalid message somehow managed to reach
the pending message collection, the message would be retried
indefinitely logging exceptions on each run.

Solution: drop invalid messages.
We now provide a CLI tool that integrates all the operations
commonly performed by node operators. Currently, this CLI
allows to:

* generate private keys for the node, replacing a functionality
  that was implemented in the CCN main app directly.
* run migrations, replacing the config updater script.
Added a new command to the CCN operator CLI to run a garbage
collector on local storage. The new `gc run` command lists
all the files that are not linked to any message or permanent
pin and deletes them.

Using the --verbose option, the command will print more details
on the files it will preserve and delete. The --dry-run option
allows to run the GC without actually deleting any file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants