Feature: support Micheline-style signatures for Tezos #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed.
odesenfans
force-pushed
the
od-tezos-support-micheline-signatures
branch
from
16d848f
to
5f364fd
Compare
MHHukiewitz
approved these changes
Sep 26, 2022
| Example: 2022-09-23T14:41:19.029Z | ||
|
|
||
| :param timestamp: The timestamp to format. | ||
| :return: The formatted timestamp. |
There was a problem hiding this comment.
We will have to consider the same for the Python client. Maybe we should rather apply the python standard and I adjust the TS SDK?
There was a problem hiding this comment.
Doesn't matter to me, whatever you prefer.
On an unrelated note, how are we gonna use Tezos wallets from the Python SDK?
src/aleph/chains/tezos.py
Outdated
| @@ -10,13 +12,82 @@ | |||
| LOGGER = logging.getLogger(__name__) | |||
| CHAIN_NAME = "TEZOS" | |||
|
|
|||
| # Default dApp URI for Micheline-style signatures | |||
| DEFAULT_DAPP_URI = "aleph.im" | |||
There was a problem hiding this comment.
Suggested change
| DEFAULT_DAPP_URI = "aleph.im" | |
| DEFAULT_DAPP_URL = "https://aleph.im" |
src/aleph/chains/tezos.py
Outdated
| @@ -41,6 +115,10 @@ async def verify_signature(message: BasePendingMessage) -> bool: | |||
| public_key_hash, | |||
| ) | |||
|
|
|||
| verification_buffer = get_tezos_verification_buffer( | |||
| message, signature_type, dapp_uri | |||
There was a problem hiding this comment.
Suggested change
| message, signature_type, dapp_uri | |
| message, signature_type, dapp_url |
| "sender": "tz1VrPqrVdMFsgykWyhGH7SYcQ9avHTjPcdD", | ||
| "type": "POST", | ||
| "channel": "ALEPH-TEST", | ||
| "signature": '{"signingType":"micheline","signature":"sigXD8iT5ivdawgPzE1AbtDwqqAjJhS5sHS1psyE74YjfiaQnxWZsATNjncdsuQw3b9xaK79krxtsC8uQoT5TcUXmo66aovT","publicKey":"edpkvapDnjnasrNcmUdMZXhQZwpX6viPyuGCq6nrP4W7ZJCm7EFTpS"}', |
There was a problem hiding this comment.
Suggested change
| "signature": '{"signingType":"micheline","signature":"sigXD8iT5ivdawgPzE1AbtDwqqAjJhS5sHS1psyE74YjfiaQnxWZsATNjncdsuQw3b9xaK79krxtsC8uQoT5TcUXmo66aovT","publicKey":"edpkvapDnjnasrNcmUdMZXhQZwpX6viPyuGCq6nrP4W7ZJCm7EFTpS"}', | |
| "signature": '{"dAppUrl": "aleph.im", "signingType":"micheline","signature":"sigXD8iT5ivdawgPzE1AbtDwqqAjJhS5sHS1psyE74YjfiaQnxWZsATNjncdsuQw3b9xaK79krxtsC8uQoT5TcUXmo66aovT","publicKey":"edpkvapDnjnasrNcmUdMZXhQZwpX6viPyuGCq6nrP4W7ZJCm7EFTpS"}', |
src/aleph/chains/tezos.py
Outdated
|
|
||
|
|
||
| def get_tezos_verification_buffer( | ||
| message: BasePendingMessage, signature_type: TezosSignatureType, dapp_uri: str |
There was a problem hiding this comment.
Suggested change
| message: BasePendingMessage, signature_type: TezosSignatureType, dapp_uri: str | |
| message: BasePendingMessage, signature_type: TezosSignatureType, dapp_url: str |
src/aleph/chains/tezos.py
Outdated
| return verification_buffer | ||
| elif signature_type == TezosSignatureType.MICHELINE: | ||
| return micheline_verification_buffer( | ||
| verification_buffer, message.time, dapp_uri |
There was a problem hiding this comment.
Suggested change
| verification_buffer, message.time, dapp_uri | |
| verification_buffer, message.time, dapp_url |
minum required change
MHHukiewitz
reviewed
Sep 26, 2022
odesenfans
added a commit
that referenced
this pull request
Oct 17, 2022
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
odesenfans
added a commit
that referenced
this pull request
Oct 27, 2022
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
odesenfans
added a commit
that referenced
this pull request
Jan 9, 2023
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
odesenfans
added a commit
that referenced
this pull request
Mar 21, 2023
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
This was referenced Apr 14, 2023
Merged
Merged
Closed
odesenfans
added a commit
that referenced
this pull request
Apr 24, 2023
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format.
Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon.
Users can now use Micheline or raw signatures by specifying the
signature.signingTypefield to "micheline" or "raw". By default, "raw" is assumed.