[Messages] Reception and confirmation times #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #265. |
odesenfans
force-pushed
the
od-introduce-new-time-fields
branch
from
9b8e5b8
to
141b617
Compare
This was referenced May 15, 2022
odesenfans
force-pushed
the
od-introduce-new-time-fields
branch
from
141b617
to
f5313c0
Compare
Problem: web wallets do not allow signing raw messages. Instead, they require binary payloads in a specific format. Solution: support Micheline-style signatures, i.e. signatures supported by wallets like Beacon. Users can now use Micheline or raw signatures by specifying the `signature.signingType` field to "micheline" or "raw". By default, "raw" is assumed. Co-authored-by: Mike Hukiewitz <70762838+MHHukiewitz@users.noreply.github.com>
Problem: if an invalid message somehow managed to reach the pending message collection, the message would be retried indefinitely logging exceptions on each run. Solution: drop invalid messages.
Problem: some dependencies were missing from the requirements, and letting pip sort it out led to dependency conflicts. Solution: add the dependencies to setup.cfg.
Some variable assignments were useless.
Problem: the "/api/v0/posts.json" endpoint returns a 500 error because of an invalid parameter being used in a function (an attempt to remove the MongoDB object ID from the endpoint). Solution: remove the object ID directly in the aggregate query. Added a simple test to verify that the endpoint is at least working a little bit.
Problem: the /api/v0/aggregates/{address}.json endpoint was not
tested enough.
Solution: add tests.
Use a Pydantic model instead of manual validation.
We now store the entire context of the transaction in the confirmations array of messages. This means that two additional fields are now preserved: the transaction block timestamp and the publisher. As we need to re-fetch this data from chain data, a new migration script resets the chain height to re-process all transactions. We reset the confirmation status of all messages to unconfirmed and deleted their confirmations array to let the node automatically migrate to the new format. Renamed some fields of the `TxContext` class in order to use the same format in all DB collections and to avoid a breaking change in the messages confirmation format.
Added two new fields to the messages collection. We now store the initial time of reception of a message in the `reception_time` field, and the earliest on-chain confirmation time in the `confirmation_time` field. These fields will be used to order messages more precisely/securely and to compute metrics, for example the propagation time of a message on the network. The `time` field of messages is now deprecated, as it is defined by users and not signed. If you need the user time, use `content.time`.
odesenfans
force-pushed
the
od-introduce-new-time-fields
branch
from
f5313c0
to
d70793f
Compare
hoh
reviewed
Oct 13, 2022
| try: | ||
| updates[k].update(v) | ||
| except KeyError: | ||
| updates[k] = v |
There was a problem hiding this comment.
So this is just merging dictionaries ?
updates.update(confirmation_updates)There was a problem hiding this comment.
It's merging two dicts of dicts. Could be written a bit cleaner, maybe.
There was a problem hiding this comment.
Oh, I see. Yes, there should be a cleaner way. Else at least a dedicated testable function to do just that.
odesenfans
force-pushed
the
dev
branch
2 times, most recently
from
d9f920c
to
3d016e0
Compare
|
Integrated in work on Postgres. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new fields to the messages collection. We now store
the initial time of reception of a message in the
reception_timefield, and the earliest on-chain confirmation time in
the
confirmation_timefield.These fields will be used to order messages more precisely/securely
and to compute metrics, for example the propagation time of a message
on the network.
The
timefield of messages is now deprecated, as it is definedby users and not signed. If you need the user time, use
content.time.