Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pythom 3.12 fails setup libsecp256k1 #132

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix: Pythom 3.12 fails setup libsecp256k1 #132

merged 1 commit into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. Fix: Pythom 3.12 fails setup libsecp256k1

    When "using bundled libsecp256k1", the setup using `/tmp/venv/bin/hatch run testing:test` fails to proceed on Python 3.12.
    
    That library `secp256k1` has been unmaintained for more than 2 years now (0.14.0, Nov 6, 2021), and seems to not support Python 3.12.
    
    The error in the logs:
    ```
    File "/tmp/pip-build-env-ye8d6ort/overlay/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 862, in get_command_obj
     cmd_obj = self.command_obj[command] = klass(self)
                                                    ^^^^^^^^^^^
          TypeError: 'NoneType' object is not callable
          [end of output]
    ```
    
    See failing CI run:
    https://github.com/aleph-im/aleph-sdk-python/actions/runs/9613634583/job/26516767722
    hoh committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8afd654 View commit details
    Browse the repository at this point in the history