Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pythom 3.12 fails setup libsecp256k1 #132

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix: Pythom 3.12 fails setup libsecp256k1 #132

merged 1 commit into from
Jun 25, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Jun 21, 2024

When "using bundled libsecp256k1", the setup using /tmp/venv/bin/hatch run testing:test fails to proceed on Python 3.12.

That library secp256k1 has been unmaintained for more than 2 years now (0.14.0, Nov 6, 2021), and seems to not support Python 3.12.

The error in the logs:

File "/tmp/pip-build-env-ye8d6ort/overlay/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 862, in get_command_obj
 cmd_obj = self.command_obj[command] = klass(self)
                                                ^^^^^^^^^^^
      TypeError: 'NoneType' object is not callable
      [end of output]

See failing CI run:
https://github.com/aleph-im/aleph-sdk-python/actions/runs/9613634583/job/26516767722

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Jun 21, 2024
Copy link

Summary:
This PR introduces a change to the GitHub Actions workflow configuration. The modification involves updating the matrix of Python versions to exclude Python 3.12, due to an issue that prevents it from working. This change does not affect the overall functionality of the project but ensures that the workflow does not fail unnecessarily.

Highlight:

-       python-version: [ "3.9", "3.10", "3.11", "3.12" ]
+       python-version: [ "3.9", "3.10", "3.11" ] # An issue prevents Python 3.12 from working

This change is considered 'BLUE' because it is a straightforward update to the workflow configuration, which does not introduce significant risks or changes to the core functionality of the project. The exclusion of Python 3.12 is noted, but the overall impact on the project is minimal.

@hoh hoh requested a review from nesitor June 21, 2024 12:53
Copy link
Collaborator

@Psycojoker Psycojoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM except the comment

What is our long term plan to address this issue? Should we find another more maintained library?

.github/workflows/pytest.yml Outdated Show resolved Hide resolved
When "using bundled libsecp256k1", the setup using `/tmp/venv/bin/hatch run testing:test` fails to proceed on Python 3.12.

That library `secp256k1` has been unmaintained for more than 2 years now (0.14.0, Nov 6, 2021), and seems to not support Python 3.12.

The error in the logs:
```
File "/tmp/pip-build-env-ye8d6ort/overlay/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 862, in get_command_obj
 cmd_obj = self.command_obj[command] = klass(self)
                                                ^^^^^^^^^^^
      TypeError: 'NoneType' object is not callable
      [end of output]
```

See failing CI run:
https://github.com/aleph-im/aleph-sdk-python/actions/runs/9613634583/job/26516767722
@hoh
Copy link
Member Author

hoh commented Jun 25, 2024

LGFM except the comment

What is our long term plan to address this issue? Should we find another more maintained library?

The discussion on that topic is here: baking-bad/pytezos#370

@Psycojoker Psycojoker merged commit 06e0335 into main Jun 25, 2024
15 checks passed
@Psycojoker Psycojoker deleted the hoh-strategy branch June 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants