feat: add properties and functions to client and server #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
changed the title
vasco-santos
changed the title
|
Note: tests are failing same way as already failing in master branch |
jacobheun
reviewed
Sep 24, 2019
client.js
Outdated
| @@ -7,12 +7,14 @@ var wsurl = require('./ws-url') | |||
|
|
|||
| module.exports = function (addr, opts) { | |||
| const location = typeof window === 'undefined' ? {} : window.location | |||
| opts = opts || {} | |||
There was a problem hiding this comment.
I'd move this to a default param instead of checking here. module.exports = function (addr, opts = {}) {
client.js
Outdated
|
|
||
| const stream = duplex(socket, opts) | ||
| stream.remoteAddress = url | ||
| stream.socket = socket |
There was a problem hiding this comment.
Is this needed? Can we map stream.destroy to socket.terminate? This would give users the forceful close option.
server.js
Outdated
| @@ -41,6 +41,9 @@ module.exports = !WebSocket.Server ? null : function (opts, onConnection) { | |||
| wsServer.on('connection', function (socket, req) { | |||
| var stream = ws(socket) | |||
| stream.remoteAddress = req.socket.remoteAddress | |||
| stream.remotePort = req.socket.remotePort | |||
| stream.close = () => emitter.close() | |||
There was a problem hiding this comment.
Shouldn't emitter.close() be socket.close()? emitter.close is going to shut the whole server down, not close the connection.
I'd also map stream.destroy to socket.terminate for consistency with the returned client streams.
vasco-santos
force-pushed
the
feat/add-properties-and-functions-to-client-and-server
branch
2 times, most recently
from
d68d064
to
dcb13a6
Compare
vasco-santos
force-pushed
the
feat/add-properties-and-functions-to-client-and-server
branch
from
dcb13a6
to
c78168d
Compare
alanshaw
approved these changes
Feb 7, 2020
vasco-santos
deleted the
feat/add-properties-and-functions-to-client-and-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of libp2p/js-libp2p-websockets#92, as well as https://github.com/libp2p/interface-transport#multiaddrconnection, a few properties were added