Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

refactor: async with multiaddr conn #92

Merged
merged 18 commits into from
Sep 30, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Sep 20, 2019

BREAKING CHANGE: Switch to using async/await and async iterators. The transport and connection interfaces have changed.

Compliant with the newest ibp2p/interface-transport

Branched of #82

I added a local test for using wss multiaddr, which was not tested in the older version. However, I created #93 to test wss using the interface-transport tests in the future.

Needs:

Alan Shaw added 16 commits September 17, 2019 11:47
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Async await changes merged but not released :(

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@vasco-santos vasco-santos force-pushed the refactor/async-with-multiaddr-conn branch from 8991a3b to 382b37a Compare September 23, 2019 13:12
@vasco-santos vasco-santos changed the title Refactor/async with multiaddr conn refactor: async with multiaddr conn Sep 23, 2019
@vasco-santos vasco-santos force-pushed the refactor/async-with-multiaddr-conn branch from 382b37a to c97a0f3 Compare September 23, 2019 15:59
@vasco-santos vasco-santos marked this pull request as ready for review September 23, 2019 16:01
src/listener.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
test/browser.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
@vasco-santos vasco-santos force-pushed the refactor/async-with-multiaddr-conn branch 2 times, most recently from d884ea6 to 227c369 Compare September 24, 2019 18:08
src/index.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
src/socket-to-conn.js Outdated Show resolved Hide resolved
test/node.js Outdated Show resolved Hide resolved
@vasco-santos vasco-santos force-pushed the refactor/async-with-multiaddr-conn branch from 227c369 to a1dfb3b Compare September 26, 2019 11:43
package.json Outdated Show resolved Hide resolved
@vasco-santos vasco-santos force-pushed the refactor/async-with-multiaddr-conn branch from 0a4717f to f610735 Compare September 27, 2019 08:48
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@jacobheun jacobheun merged commit ce7bf4f into master Sep 30, 2019
@jacobheun jacobheun deleted the refactor/async-with-multiaddr-conn branch September 30, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants