Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CIDR and wildcard matching (rebased version of #21) #28

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

akrabat
Copy link
Owner

@akrabat akrabat commented Dec 7, 2020

This is a rebased version of #21:

Only activated if trusted proxy value contains a "*" (wildcard) or "/" (CIDR).
Uses strpos() on object-creation, so very low performance hit.
Tests are included.

I need CIDR matching for using this library within a load-balanced AWS VPC. There is no way to accurately predict the IP addresses for the load balancer nodes, you only know the IP range via CIDR block.

Only activated if trusted proxy value contains a "*" (wildcard) or "/" (CIDR)
@akrabat akrabat closed this in 6eb0187 Dec 7, 2020
@akrabat akrabat merged commit 6eb0187 into master Dec 7, 2020
@akrabat akrabat added this to the 2.0 milestone Dec 7, 2020
@akrabat akrabat deleted the homeyjd/master branch December 7, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants