Add CIDR and wildcard matching #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only activated if trusted proxy value contains a "*" (wildcard) or "/" (CIDR)
|
I too need this functionality. |
|
Hi @homeyjd Sorry, I saw your code just after I commited my own code. I think my code is a bit cleaner (no offence), although I only support CIDR. I really don't see the need for wildcards. |
This was referenced Dec 7, 2020
|
I have no excuse for how long this has taken me to get to. I'm taking this, but it needed rebasing, which is #28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only activated if trusted proxy value contains a "*" (wildcard) or "/" (CIDR).
Uses strpos() on object-creation, so very low performance hit.
Tests are included.
I need CIDR matching for using this library within a load-balanced AWS VPC. There is no way to accurately predict the IP addresses for the load balancer nodes, you only know the IP range via CIDR block.