Akka.Remote: harden EndpointWriter against serialization failures
#7923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Oct 24, 2025
| ByteString pdu; | ||
| try | ||
| { | ||
| pdu = _codec.ConstructMessage(send.Recipient.LocalAddressToUse, send.Recipient, |
There was a problem hiding this comment.
Wrap all concerns related to outbound serialization in an additional try...catch - throw the inner exception inside a new SerializationException since the outer try...catch knows to log those without disassociating.
| LogPossiblyWrappedMessageType(send.Message)); | ||
| return true; | ||
| } | ||
| catch (ArgumentException ex) |
There was a problem hiding this comment.
This additional catch is now redundant given the inner try...catch
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Oct 24, 2025
Aaronontheweb
added a commit
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #7922 - hardens the Akka.Remote
EndpointWriteragainst a larger range of potential serialization failures.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):