Akka.Remote: harden EndpointWriter against serialization failures (#7923) (#7925)

close #7922

Author: Aaronontheweb

src/core/Akka.Remote/Endpoint.cs

@@ -1481,8 +1481,17 @@ private bool WriteSend(EndpointManager.Send send)
                         send.Recipient, send.Recipient.Path, send.SenderOption ?? _system.DeadLetters);
                 }
 
-                var pdu = _codec.ConstructMessage(send.Recipient.LocalAddressToUse, send.Recipient,
-                    SerializeMessage(send.Message), send.SenderOption, send.Seq, _lastAck);
+                ByteString pdu;
+                try
+                {
+                    pdu = _codec.ConstructMessage(send.Recipient.LocalAddressToUse, send.Recipient,
+                        SerializeMessage(send.Message), send.SenderOption, send.Seq, _lastAck);
+                }
+                catch (Exception e) when (e is not SerializationException)
+                {
+                    // resolves https://github.com/akkadotnet/akka.net/issues/7922
+                    throw new SerializationException("Serializer failed with exception", e);
+                }
 
                 _remoteMetrics.LogPayloadBytes(send.Message, pdu.Length);
 
@@ -1518,14 +1527,6 @@ private bool WriteSend(EndpointManager.Send send)
                   LogPossiblyWrappedMessageType(send.Message));
                 return true;
             }
-            catch (ArgumentException ex)
-            {
-                _log.Error(
-                  ex,
-                  "Serializer threw ArgumentException for message type [{0}]. Transient association error (association remains live)",
-                  LogPossiblyWrappedMessageType(send.Message));
-                return true;
-            }
             catch (EndpointException ex)
             {
                 PublishAndThrow(ex, LogLevel.ErrorLevel);