implicitly convert regular BusLogger to SerilogLoggingAdapter when ForContext is called
#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `ForContext` is called close akkadotnet#284
Aaronontheweb
commented
May 29, 2024
| @@ -17,6 +17,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{489D8D37 | |||
| build.sh = build.sh | |||
| src\Directory.Build.props = src\Directory.Build.props | |||
| src\Directory.Packages.props = src\Directory.Packages.props | |||
| NuGet.config = NuGet.config | |||
There was a problem hiding this comment.
Make it easier to edit NuGet.config from within the IDE
| /// Used to test that https://github.com/akkadotnet/Akka.Logger.Serilog/issues/284 is fixed | ||
| /// </summary> | ||
| [Fact] | ||
| public void ShouldLogMessageWithContextPropertyDefaultLogger() |
There was a problem hiding this comment.
Added tests that start with a default BugLogger and ensure that the output matches what a user would see with the SerilogLoggingAdapter under the same conditions.
| @@ -15,7 +15,18 @@ public static class SerilogLoggingAdapterExtensions | |||
| /// <param name="destructureObjects">If true, the value will be serialized as a structured object if possible; if false, the object will be recorded as a scalar or simple array.</param> | |||
| public static ILoggingAdapter ForContext(this ILoggingAdapter adapter, string propertyName, object value, bool destructureObjects = false) | |||
| { | |||
| return adapter is not SerilogLoggingAdapter customAdapter ? adapter : customAdapter.SetContextProperty(propertyName, value, destructureObjects); | |||
| if(adapter is SerilogLoggingAdapter customAdapter) | |||
src/Directory.Build.props
Outdated
| @@ -12,7 +12,7 @@ | |||
| <LangVersion>10</LangVersion> | |||
| </PropertyGroup> | |||
| <PropertyGroup> | |||
| <AkkaVersion>1.5.14</AkkaVersion> | |||
| <AkkaVersion>1.5.22-beta1</AkkaVersion> | |||
There was a problem hiding this comment.
Used a local beta that I created - will require Akka.NET v1.5.22 once that ships.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #284 - requires akkadotnet/akka.net#7210 to be merged and Akka.NET v1.5.22 to get shipped.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
ILoggingAdapterintoSerilogLoggingAdapterwhenFromContextis called. #284