Akka.Event: expose the EventStream on BusLogging for extensibility purposes
#7210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
May 28, 2024
There was a problem hiding this comment.
These changes are trivial, but detailed them anyway. Going to test these using a local build of Akka.NET to ensure that akkadotnet/Akka.Logger.Serilog#284 can be implemented successfully with this change before we merge it.
| @@ -14,9 +15,22 @@ namespace Akka.Event | |||
| /// </summary> | |||
| public sealed class BusLogging : LoggingAdapterBase | |||
| { | |||
| private readonly LoggingBus _bus; | |||
There was a problem hiding this comment.
Made these properties public and tried to add some actually-helpful comments.
5 tasks
|
Added akkadotnet/Akka.Logger.Serilog#285 as a proof of concept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #7209
The idea behind this feature is to make it possible to implement akkadotnet/Akka.Logger.Serilog#284 - automatically add
Contextto anILoggingAdapterby just callingForContextwithout having to explicitly request aSerilogLoggingAdapterfirst. All that's needed to make this work is to make some of the internal data members of theBugLoggingmember public and read-onlyChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
EventStreamonBusLoggingfor extensibility purposes #7209