Fix IR checking errors #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of writing the class directory to a config file, and *depending* on the `akkaJsActorIrPatches` project, we simply read `products in (akkaJsActorIrPatches, Compile)`. In addition to being substandard in terms of sbt task dependency graph, the previous solution caused the classDirectory of the IR patches to end up in `akkaJsActor`'s `fullClasspath` (despite the `% "provided"`). Although this did not have an impact on published artifacts (AFAICT), it polluted the set of IR files seen in this build.
In the full sources, `Actor` is a `trait`, so its IR patch must also be a `trait` to produce the correct IR nodes.
|
thanks for your improvements, |
|
it turned out that turning |
|
Could I kindly ask to separate this into two PR so that I can immediately accept first one and, in the mean-while, find a fix for the second one please |
|
Sure: #75. |
|
sounds good, thanks |
|
things in this PR already got targeted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with the Scala.js PRs scala-js/scala-js#3059 and scala-js/scala-js#3061, this fixes the IR checking errors visible in
akkaJsActorJS/fastOptJSandakkaActorTestJS/test:fastOptJS.Unfortunately we cannot enable IR checking in this build yet, because that will only work after upgrading to Scala.js 0.6.19, once it is released.