Fix #3058: Use the proper type for the "thisLocalVar" of tailrec. #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
reviewed
Jul 14, 2017
| if (tryingToGenMethodAsJSFunction) { | ||
| throw new CancelGenMethodAsJSFunction( | ||
| "Trying to generate `this` inside the body") | ||
| } | ||
| js.This()(currentClassType) | ||
| } { thisLocalIdent => | ||
| js.VarRef(thisLocalIdent)(currentClassType) | ||
| } { thisLocalInfo => |
There was a problem hiding this comment.
case (thisLocalIdent, thisLocalTpe) =>?
…rec. In Scala 2.12, if a tail-recursive method is in a class or trait with a self-type, the type of the `_$this` local variable is the self type. We previously assumed it was always the current class type, which produced invalid IR in that case.
sjrd
force-pushed
the
fix-invalid-ir-tailrec-trait-2.12
branch
from
f99b7be to
1518b70
Compare
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4117/ |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4118/ |
gzm0
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Scala 2.12, if a tail-recursive method is in a class or trait with a self-type, the type of the
_$thislocal variable is the self type. We previously assumed it was always the current class type, which produced invalid IR in that case.