forked from commons-app/apps-android-commons
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update to API 28, and fix CI issues. (commons-app#2595)
* Update gradle version. Also update jacoco plugin to work with latest gradle. * Update target sdk to 28. * Update other dependencies to latest versions. * Remove totally unused(?) local jar file. * Remove dependency on nineoldandroids. The functions it provides are no longer necessary. This also removes a homemade "evaluate" function, which is readily available in the Support library. * Remove dependency on Traceur. This library has not been updated in two years (may no longer be maintained?), and no longer works with the latest RxJava. * Enable test coverage only when performing CI. Running test coverage on every single build while developing in the IDE is quite a waste of time. * Suppress gradle Notes and Warnings from reflection-using packages. The build output was getting extremely long, and was actually causing the build to fail because of the sheer size of the log. * Suppress gradle Note messages during tests and CI. Stop CI messages from exploding to 10k+ lines. * Temporarily remove instrumented test(s). The project's instrumented tests consist of a single test which sets a SharedPreference, then verified that the SharedPreference was set. I humbly submit that this is not worth the trouble of having the CI server download the system image, spin up an emulator, load the APK, and run it just for this purpose. Once the instrumented tests are ready for prime time, we can reinstate instrumented tests in CI.
- Loading branch information
1 parent
8dbeb6e
commit c21cc83
Showing
10 changed files
with
26 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,5 @@ | |
-dontoptimize | ||
-dontshrink | ||
-ignorewarnings | ||
|
||
-dontnote ** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#Sat Nov 03 11:02:51 CET 2018 | ||
#Thu Mar 14 14:54:52 EDT 2019 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip |