Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprint 11] New features and fixes #278

Merged
merged 52 commits into from
Aug 2, 2024
Merged

[Sprint 11] New features and fixes #278

merged 52 commits into from
Aug 2, 2024

Conversation

imda-lionelteo
Copy link
Collaborator

@imda-lionelteo imda-lionelteo commented Jul 30, 2024

Description

In Sprint 11, there are new features introduced.

  1. Introduce new pagination function to CLI. [MS-258] updated all CLI list commands with pagination #277
  2. Dataset Converter. [MS-334] Dataset Converter #269
  3. Removal of Generating Dynamic benchmark Prompts. [MS-292] Removal of generating dynamic benchmark prompts on the fly #271
  4. Fix bug where logger where keeps displaying multiple similar lines when using run_recipe or run_cookbooks. [MS-351] Fix bug where logger keeps displaying multiple repeated logs #273
  5. Fix bug where ART returns pt_id error. [MS-352] fix cli art pt #272
  6. Other additional works. update unittest for bookmark web-api #267, Ms 347 #281, [MS-347] Patch unit tests for Sprint 10  #276

Motivation and Context

To introduce more features and fixes for Moonshot.

Type of Change

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation updates

How to Test

[Provide clear instructions on how to test and verify the changes introduced by this pull request, including any specific unit tests you have created to demonstrate your changes.]

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

@imda-lionelteo imda-lionelteo self-assigned this Jul 30, 2024
@imda-lionelteo imda-lionelteo marked this pull request as draft July 30, 2024 03:59
Norman Chia and others added 3 commits July 30, 2024 13:39
@imda-lionelteo imda-lionelteo marked this pull request as ready for review July 30, 2024 09:40
Copy link
Contributor

@imda-benedictlee imda-benedictlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs in this PR for Sprint 11 has been tested and verified to work. Approved.

@imda-benedictlee imda-benedictlee merged commit 155cac3 into main Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants