Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS-352] fix cli art pt #272

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[MS-352] fix cli art pt #272

merged 2 commits into from
Jul 29, 2024

Conversation

imda-kelvinkok
Copy link
Collaborator

Description

Bug fix for ticket raised here #270
If we use prompt template with attack modules, there will be a pydantic validation error.

Motivation and Context

Bug fix

Type of Change

A bug fix

How to Test

  1. Start Moonshot in CLI: python -m moonshot cli interactive
  2. Start a new session with an endpoint you want to use with new_session
  3. Set a prompt template in that session: use_prompt_template real-toxicity-prompt-template1
  4. Run attack module: run_attack_module toxic_sentence_generator "this is my prompt". There shouldn't be a pydantic validation error when the attack module runs

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

Additional Notes

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

imda-benedictlee and others added 2 commits July 23, 2024 15:09
[Sprint 10] New features and fixes

The requested reviews are Approved. Proceed to merge PR to Main.
@imda-benedictlee
Copy link
Contributor

Tested Fix. Working as expected.

Screen.Recording.2024-07-26.at.3.32.05.PM.mov

@imda-lionelteo imda-lionelteo changed the title Ms 352 fix cli art pt [MS-352] fix cli art pt Jul 29, 2024
@imda-lionelteo imda-lionelteo merged commit 08e6f0c into dev_main Jul 29, 2024
1 of 2 checks passed
@imda-benedictlee
Copy link
Contributor

@imda-benedictlee
Copy link
Contributor

Tested. Working as expected.

Screen.Recording.2024-07-30.at.8.19.09.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants