Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS-294] Removal of attack modules field in all recipes #69

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

imda-lionelteo
Copy link
Collaborator

Description

Removal of attack modules field in the recipe

Motivation and Context

Remove the attack module because it is no longer required for augmented benchmark.
Previously this is needed as dynamic benchmarking runs the dataset and pass the dataset prompt to the attack modules that are defined in the recipe.

Now, this is not needed because there is another path that will augment and save it as a new dataset and recipe before it will run the benchmarking.

Type of Change

  • feat: A new feature

How to Test

This is a sub-test that needs to be tested with MS-292 to ensure that it will still run properly.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

This is a sub-test that needs to be tested with MS-292 to ensure that it will still run properly.

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

@imda-lionelteo imda-lionelteo marked this pull request as draft July 19, 2024 04:13
@imda-lionelteo imda-lionelteo self-assigned this Jul 19, 2024
@imda-lionelteo imda-lionelteo marked this pull request as ready for review July 24, 2024 06:19
@imda-kelvinkok imda-kelvinkok merged commit a7f9a0d into dev_main Jul 25, 2024
@imda-lionelteo imda-lionelteo deleted the ms-294 branch July 29, 2024 14:38
@imda-benedictlee
Copy link
Contributor

@imda-benedictlee
Copy link
Contributor

Tested. Working as expected.

Screenshot 2024-07-31 at 4 59 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants