Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-postgres: read() throws config exception upon xmin wraparound #38875

Merged
merged 8 commits into from
Jun 5, 2024
Merged

source-postgres: read() throws config exception upon xmin wraparound #38875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de72a9a
source-postgres: read() throws config exception upon xmin wraparound
theyueli Jun 3, 2024
f83c87d
bump up dockerImageTag
theyueli Jun 5, 2024
31b149f
Merge branch 'master' into yue/readxmin
theyueli Jun 5, 2024
3ad6aa2
changelog
theyueli Jun 5, 2024
9833b48
change log and version changes
theyueli Jun 5, 2024
ae0d42e
code review
theyueli Jun 5, 2024
154a253
clean
theyueli Jun 5, 2024
bd82b2a
format
theyueli Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-postgres/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: decd338e-5647-4c0b-adf4-da0e75f5a750
dockerImageTag: 3.4.12
dockerImageTag: 3.4.13
dockerRepository: airbyte/source-postgres
documentationUrl: https://docs.airbyte.com/integrations/sources/postgres
githubIssueLabel: source-postgres
Expand Down
5 changes: 5 additions & 0 deletions ...source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@ public List<AutoCloseableIterator<AirbyteMessage>> getIncrementalIterators(final
final XminStatus xminStatus;
try {
xminStatus = PostgresQueryUtils.getXminStatus(database);
if (xminStatus.getNumWraparound() > 0) {
throw new ConfigErrorException("We detected XMIN transaction wraparound in the database, " +
"which makes this sync option inefficient and can lead to higher credit consumption. " +
"Please change the replication method to CDC or cursor based.");
}
} catch (SQLException e) {
throw new RuntimeException(e);
}
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/postgres.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ According to Postgres [documentation](https://www.postgresql.org/docs/14/datatyp

| Version | Date | Pull Request | Subject |
|---------|------------|----------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 3.4.13 | 2024-06-04 | [38875](https://github.com/airbytehq/airbyte/pull/38875) | read() throws config exception upon detecting transaction ID wraparound. |
| 3.4.12 | 2024-06-04 | [38836](https://github.com/airbytehq/airbyte/pull/38836) | check() throws config error upon detecting transaction ID wraparound. |
| 3.4.11 | 2024-06-04 | [38848](https://github.com/airbytehq/airbyte/pull/38848) | Improve UI message and doc on xmin |
| 3.4.10 | 2024-05-29 | [38584](https://github.com/airbytehq/airbyte/pull/38584) | Set is_resumable flag in discover. |
Expand Down
Loading