-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-postgres: read() throws config exception upon xmin wraparound #38875
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this!
We actually get the xmin status in the read path here : https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java#L503
We can just piggyback there, check if xmin wraparound is > 0 and throw a config error there. It's not clear to me we will require a standalone method there at this point
agreed, that's indeed very convenient. Thanks for pointing to this place. I actually didn't notice the function is already called there. Revised, please take another look. |
fixes https://github.com/airbytehq/airbyte-internal-issues/issues/8006