Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-postgres: read() throws config exception upon xmin wraparound #38875

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

theyueli
Copy link
Contributor

@theyueli theyueli commented Jun 3, 2024

@theyueli theyueli self-assigned this Jun 3, 2024
@theyueli theyueli requested a review from a team as a code owner June 3, 2024 19:46
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 7:33am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/postgres labels Jun 3, 2024
@theyueli theyueli requested a review from a team as a code owner June 5, 2024 01:01
Copy link
Contributor

@akashkulk akashkulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this!

We actually get the xmin status in the read path here : https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java#L503

We can just piggyback there, check if xmin wraparound is > 0 and throw a config error there. It's not clear to me we will require a standalone method there at this point

@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jun 5, 2024
@theyueli
Copy link
Contributor Author

theyueli commented Jun 5, 2024

Thanks for taking this!

We actually get the xmin status in the read path here : https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java#L503

We can just piggyback there, check if xmin wraparound is > 0 and throw a config error there. It's not clear to me we will require a standalone method there at this point

agreed, that's indeed very convenient. Thanks for pointing to this place. I actually didn't notice the function is already called there. Revised, please take another look.

@theyueli theyueli requested a review from a team June 5, 2024 07:11
@theyueli theyueli merged commit 859b596 into master Jun 5, 2024
31 checks passed
@theyueli theyueli deleted the yue/readxmin branch June 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants