[connectors_qa] Remove DOCKER_HUB_USERNAME check #38017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Let DOCKER_HUB_USERNAME be checked in `metadata_lib` instead. It will error out if it's missing anyway. - Remove redundant check on documentation file in MetadataValidator. It's already checked in `documentation_validator` separately.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@alafanechere already implemented this in #37787! So, this PR is mostly not needed, I'll see if I want to salvage the piece that extracts docs check. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR cleans up
connectors_qaa little bit, but does not change what it does functionally:metadata_libinstead. It will error out if it's missing anyway.documentation_validatorseparately.Why
I was trying to figure out CI failures in #37839, and one of them (documentation test of
connectors_qaitself) led me to running connectors_qa checks locally, which did not work, becauseDOCKER_HUB_USERNAME. I filed #38011 to address this.Also, closes #38011.
Can this PR be safely reverted and rolled back?