Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors-qa] Running pytest should not require DOCKER_HUB_USERNAME #38011

Closed
natikgadzhi opened this issue May 7, 2024 · 1 comment
Closed
Assignees
Labels
help-welcome Accepting external contributions team/extensibility

Comments

@natikgadzhi
Copy link
Contributor

Problem

I was trying to fix test failures in #37839 and running poetry run pytest tests in airbyte-ci/connectors/connectors_qa, but it wants DOCKER_HUB_USERNAME to be set to run some of the unit tests:

ERROR tests/integration_tests/test_documentation.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check
ERROR tests/unit_tests/test_checks/test_assets.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check
ERROR tests/unit_tests/test_checks/test_documentation.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check
ERROR tests/unit_tests/test_checks/test_metadata.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check
ERROR tests/unit_tests/test_checks/test_packaging.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check
ERROR tests/unit_tests/test_checks/test_security.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check
ERROR tests/unit_tests/test_models.py - ValueError: Environment variable DOCKER_HUB_USERNAME is required for this check

This doesn't sound right. Why do we need docker hub creds for a unit test of all things?

@natikgadzhi
Copy link
Contributor Author

Oh lol. @alafanechere beat me to it and actually fixed this before I even opened this issue, in #37787. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-welcome Accepting external contributions team/extensibility
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants