Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Add Airbyte-native shopify connector (replaces Singer-based) #3787

Merged
merged 60 commits into from
Jun 8, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
b315dae
first commit
Jun 1, 2021
4b85915
Delete source copy.py
bazarnov Jun 1, 2021
93a821f
IAdded Incremental Refresh + stream_slice for Refunds, Transactions
Jun 1, 2021
d2ee9c3
Merge branch 'bazarnov/3581-shopify-cdk-connector' of https://github.…
Jun 1, 2021
59cf410
small changes to source.py
Jun 1, 2021
926c914
fixed Incremental Refresh
Jun 2, 2021
718eccc
Fixed acceptence-tests
Jun 2, 2021
fc44580
Edited no-refunds-catalog for acceptence-tests
Jun 2, 2021
211307c
changed the state
Jun 2, 2021
4aa56ab
Commit for Review
Jun 2, 2021
4c52376
removed spaces
Jun 2, 2021
658b0ff
added parameter to orders stream to read all the records by default
Jun 2, 2021
6fefde0
added parameter to abandoned_checkouts stream to read all the records…
Jun 2, 2021
6c6e584
minor fix
bazarnov Jun 2, 2021
1968848
minor fix
bazarnov Jun 2, 2021
04ed53a
changed authentication method from basic http > header based auth, re…
Jun 3, 2021
5d07a3e
reformated source.py
Jun 3, 2021
4cf5d7f
improved source.py, removed dependencies block from build.gradle
bazarnov Jun 4, 2021
1885694
removed unneeded dependencies + formated source.py
bazarnov Jun 4, 2021
9c18348
changed Shopify in source_definitions.yaml from singer-based to cdk v…
bazarnov Jun 4, 2021
0ad3a27
added source_definition for source-shopify cdk json file
bazarnov Jun 4, 2021
f5ebc60
Delete airbyte-config/init/bin/main/config/STANDARD_SOURCE_DEFINITION…
bazarnov Jun 4, 2021
6cc7644
Add files via upload
bazarnov Jun 4, 2021
d114bda
added secret credentials for source-shopify
bazarnov Jun 4, 2021
29fb46f
Delete 9da77001-af33-4bcd-be46-6252bf9342b9.json
bazarnov Jun 4, 2021
4239aa8
Merge branches 'bazarnov/3581-shopify-cdk-connector' and 'bazarnov/35…
bazarnov Jun 4, 2021
f2ff982
re-added source_definition file
bazarnov Jun 4, 2021
4b89079
Delete airbyte-config/init/bin/main/config/STANDARD_SOURCE_DEFINITION…
bazarnov Jun 4, 2021
125233a
re-added source definition
bazarnov Jun 4, 2021
f21c71b
Delete airbyte-config/init/bin/main/config/STANDARD_SOURCE_DEFINITION…
bazarnov Jun 4, 2021
ab81b1d
edit source definitions
bazarnov Jun 4, 2021
7394fad
source definition change: removed icon block
bazarnov Jun 4, 2021
edd851f
...
bazarnov Jun 4, 2021
a514a78
changed source_definition.json
bazarnov Jun 4, 2021
5c8b142
changed source_definition.json
bazarnov Jun 4, 2021
7b74bfb
Added ability to specify the start_date of data replica.
bazarnov Jun 5, 2021
ae371c6
changed docker version to 0.1.1 - bumped version on image, aedited re…
bazarnov Jun 6, 2021
d32f04d
changed docker version to 0.1.1 - bumped version on image, aedited re…
bazarnov Jun 6, 2021
0b1d5dd
changed docker version to 0.1.1 - bumped version on image, aedited re…
bazarnov Jun 6, 2021
9d58054
changed collects to full_refresh by default
bazarnov Jun 6, 2021
dd3c245
changed collects to full_refresh by default
bazarnov Jun 6, 2021
71cf24b
Delete airbyte-config/.settings directory
bazarnov Jun 6, 2021
ce52fa5
Delete .classpath
bazarnov Jun 6, 2021
4e92028
Delete .project
bazarnov Jun 6, 2021
9456b02
Delete .project
bazarnov Jun 6, 2021
9a4c6c2
Delete .classpath
bazarnov Jun 6, 2021
20d1da0
Delete airbyte-config/init/.settings directory
bazarnov Jun 6, 2021
fcefa0f
Delete airbyte-config/init/bin directory
bazarnov Jun 6, 2021
6d323b9
Delete airbyte-config/models/.settings directory
bazarnov Jun 6, 2021
4da9459
Delete airbyte-config/models/bin directory
bazarnov Jun 6, 2021
676466a
Delete .classpath
bazarnov Jun 6, 2021
8d94ed2
Delete .project
bazarnov Jun 6, 2021
989d02d
Delete airbyte-config/persistence/.settings directory
bazarnov Jun 6, 2021
f294227
Delete airbyte-config/persistence/bin directory
bazarnov Jun 6, 2021
36a7c70
Delete .classpath
bazarnov Jun 6, 2021
89c4283
Delete .project
bazarnov Jun 6, 2021
a9cd0ca
changed python to python3 in README.md
bazarnov Jun 6, 2021
051f392
small changes to code source.py, bump the version, edited .gitignore
bazarnov Jun 7, 2021
e1b4473
edited spec.json with pattern for start_date
bazarnov Jun 7, 2021
3127c7e
Merge branch 'master' of https://github.com/airbytehq/airbyte into ba…
bazarnov Jun 7, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions airbyte-integrations/connectors/source-shopify/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
*
!Dockerfile
!Dockerfile.test
!main.py
!source_shopify
!setup.py
!secrets
15 changes: 15 additions & 0 deletions airbyte-integrations/connectors/source-shopify/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
FROM python:3.7-slim

# Bash is installed for more convenient debugging.
RUN apt-get update && apt-get install -y bash && rm -rf /var/lib/apt/lists/*

WORKDIR /airbyte/integration_code
COPY source_shopify ./source_shopify
COPY main.py ./
COPY setup.py ./
RUN pip install .

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.name=airbyte/source-shopify
133 changes: 133 additions & 0 deletions airbyte-integrations/connectors/source-shopify/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
# Shopify Source

This is the repository for the Shopify source connector, written in Python.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/shopify).

## Local development

### Prerequisites
**To iterate on this connector, make sure to complete this prerequisites section.**

#### Build & Activate Virtual Environment and install dependencies
From this connector directory, create a virtual environment:
```
python -m venv .venv
```

This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your
development environment of choice. To activate it from the terminal, run:
```
source .venv/bin/activate
pip install -r requirements.txt
```
If you are in an IDE, follow your IDE's instructions to activate the virtualenv.

Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is
used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`.
If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything
should work as you expect.

#### Building via Gradle
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.

To build using Gradle, from the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:source-shopify:build
```

#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/shopify)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_shopify/spec.json` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source shopify test creds`
and place them into `secrets/config.json`.

### Locally running the connector
```
python main.py spec
python main.py check --config secrets/config.json
python main.py discover --config secrets/config.json
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image:
```
docker build . -t airbyte/source-shopify:dev
```

You can also build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:source-shopify:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-shopify:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-shopify:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-shopify:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-shopify:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
First install test dependencies into your virtual environment:
```
pip install .[tests]
```
### Unit Tests
To run unit tests locally, from the connector directory run:
```
python -m pytest unit_tests
```

### Integration Tests
There are two types of integration tests: Acceptance Tests (Airbyte's test suite for all source connectors) and custom integration tests (which are specific to this connector).
#### Custom Integration tests
Place custom tests inside `integration_tests/` folder, then, from the connector root, run
```
python -m pytest integration_tests
```
#### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](source-acceptance-tests.md) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
To run your integration tests with acceptance tests, from the connector root, run
```
python -m pytest integration_tests -p integration_tests.acceptance
```
To run your integration tests with docker

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:source-shopify:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:source-shopify:integrationTest
```
To build final build the connector:
```
./gradlew :airbyte-integrations:connectors:source-shopify:build
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests.
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# See [Source Acceptance Tests](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector/source-acceptance-tests.md)
# for more information about how to configure these tests
connector_image: airbyte/source-shopify:dev
tests:
spec:
- spec_path: "source_shopify/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
# expect_records:
# path: "integration_tests/expected_records.txt"
# extra_fields: no
# exact_order: no
# extra_records: yes
# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
# incremental: # TODO if your connector does not implement incremental sync, remove this block
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
# state_path: "integration_tests/abnormal_state.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env sh
docker run --rm -it \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /tmp:/tmp \
-v $(pwd):/test_input \
airbyte/source-acceptance-test \
--acceptance-test-config /test_input
14 changes: 14 additions & 0 deletions airbyte-integrations/connectors/source-shopify/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-source-acceptance-test'
}

airbytePython {
moduleDirectory 'source_shopify'
}

dependencies {
implementation files(project(':airbyte-integrations:bases:source-acceptance-test').airbyteDocker.outputs)
implementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs)
bazarnov marked this conversation as resolved.
Show resolved Hide resolved
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"todo-stream-name": {
"todo-field-name": "todo-abnormal-value"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
#
# MIT License
#
# Copyright (c) 2020 Airbyte
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
#


import pytest

pytest_plugins = ("source_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
""" This fixture is a placeholder for external resources that acceptance test might require."""
# TODO: setup test dependencies if needed. otherwise remove the TODO comments
yield
# TODO: clean up test dependencies
Loading