-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Add Airbyte-native shopify connector (replaces Singer-based) #3787
Conversation
File doesn't need
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
…com/airbytehq/airbyte into bazarnov/3581-shopify-cdk-connector
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
…moved usage of api_key
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question and one suggestion, almost there!
Also a couple of comments:
- you should edit the repo's root
.gitignore
to ignore the files which messed up the PR diff so you don't have this issue in the future - in the future make sure to wait for a PR approval to run the
publish
command ;)
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/spec.json
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-shopify
|
5663e2e
to
e1b4473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢 🚢 🚢
0206329
to
e1b4473
Compare
/publish connector=connectors/source-shopify
|
…zarnov/3581-shopify-cdk-connector
Bravo!!! for this new connector. It makes life much easier. I love the fact that it does not even use the Shopify CDK and uses the API endpoints directly. I tested it and its working perfectly for me. I'm going to add a couple of endpoints that my team needs into it as described in the following issue #3576 |
What
#3581 new source: Airbyte-native Shopify connector
How
Using Airbyte's Python CDK, implemented the logic for source-shopify connector, with the same endpoint as shopify-singer connector has.
By default, it pulls out all the data, then keeps it fresh using the incremental refresh (incremental should be selected as an option inside connection settings)
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
/test
command documented here is passing.docs/integrations/
directory./publish
command described here