Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nullable from generics #37555

Merged

Conversation

stephane-airbyte
Copy link
Contributor

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 6:39pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 24, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 5d1b68b to b3fd99e Compare April 24, 2024 22:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from 5ed5a0a to e61b85a Compare April 24, 2024 22:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from b3fd99e to 2b8f4bb Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from e61b85a to bdb656b Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 2b8f4bb to e92ae48 Compare April 25, 2024 01:20
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch 2 times, most recently from da670de to b78c13e Compare April 25, 2024 14:58
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from e92ae48 to a49d264 Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from b78c13e to ae9e306 Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from a49d264 to 1921820 Compare May 22, 2024 19:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from ae9e306 to ced5117 Compare May 22, 2024 19:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 1921820 to 33f3a50 Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from ced5117 to d002a2d Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 33f3a50 to 2fd07b2 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from d002a2d to b203d86 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 2fd07b2 to 2dfe157 Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from b203d86 to a4961f5 Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 2dfe157 to a9ae0e8 Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from a4961f5 to 9f4d61b Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from 9f4d61b to caca8fd Compare May 22, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 5d48aec to e6ef20e Compare May 22, 2024 23:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from caca8fd to 939aa70 Compare May 22, 2024 23:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from e6ef20e to 1a21a77 Compare May 22, 2024 23:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from 939aa70 to 57b123e Compare May 22, 2024 23:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 1a21a77 to 57615ce Compare May 23, 2024 00:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from 57b123e to e7d7e90 Compare May 23, 2024 00:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from 57615ce to b126b06 Compare May 23, 2024 03:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from e7d7e90 to 41e795c Compare May 23, 2024 03:53
@stephane-airbyte stephane-airbyte marked this pull request as ready for review May 23, 2024 05:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_unnecessary_calls_to_tolist_ branch from b126b06 to a7b52c0 Compare May 23, 2024 14:22
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch 2 times, most recently from 936be01 to 9167bae Compare May 23, 2024 14:27
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamping

Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a lot of useless nullable things πŸ˜…

Copy link
Contributor Author

stephane-airbyte commented May 23, 2024

Merge activity

@stephane-airbyte stephane-airbyte changed the base branch from stephane/04-24-remove_unnecessary_calls_to_tolist_ to graphite-base/37555 May 23, 2024 18:22
@stephane-airbyte stephane-airbyte changed the base branch from graphite-base/37555 to master May 23, 2024 18:37
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_nullable_from_generics branch from 9167bae to 5c65df2 Compare May 23, 2024 18:38
@stephane-airbyte stephane-airbyte merged commit d82639c into master May 23, 2024
27 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/04-24-remove_nullable_from_generics branch May 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants