Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace all java Collectors.toList with kotlin construct #37537

Merged
merged 1 commit into from
May 23, 2024
Merged

replace all java Collectors.toList with kotlin construct #37537

merged 1 commit into from
May 23, 2024

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Apr 24, 2024 •
edited
Loading

more kotlin cleanup

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 5:56pm

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Apr 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte mentioned this pull request Apr 24, 2024
Merged
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from 7b904ab to 24491d6 Compare April 24, 2024 15:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch 2 times, most recently from e7b0a93 to 6d44ded Compare April 24, 2024 16:21
@stephane-airbyte stephane-airbyte mentioned this pull request Apr 24, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from 24491d6 to 21fe931 Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 6d44ded to 9a6ddf1 Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte mentioned this pull request Apr 25, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from 21fe931 to 2236ecd Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 9a6ddf1 to 34b8e6b Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from 2236ecd to 456d9f9 Compare May 22, 2024 19:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 34b8e6b to abcd37c Compare May 22, 2024 19:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from 456d9f9 to 6ef3917 Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from abcd37c to 8346939 Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from 6ef3917 to cd400d2 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch 2 times, most recently from 58a3fb0 to ff32b39 Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte mentioned this pull request May 22, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from cd400d2 to aedfd3f Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from ff32b39 to de84e79 Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte mentioned this pull request May 22, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch 2 times, most recently from b8397c6 to 610061c Compare May 22, 2024 23:10
@stephane-airbyte stephane-airbyte marked this pull request as ready for review May 23, 2024 05:34
@stephane-airbyte stephane-airbyte requested review from a team, akashkulk, edgao, gisripa, postamar and rodireich and removed request for a team May 23, 2024 05:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-cleanup_question_marks_in_cdk_code branch from aedfd3f to 34438f8 Compare May 23, 2024 14:21
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 610061c to ea6f22e Compare May 23, 2024 14:21
edgao
edgao approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp (... I swear I reviewed this PR just now, maybe that was a hallucination)

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented May 23, 2024 •
edited
Loading

Merge activity

@stephane-airbyte stephane-airbyte changed the base branch from stephane/04-23-cleanup_question_marks_in_cdk_code to graphite-base/37537 May 23, 2024 17:53
@stephane-airbyte stephane-airbyte changed the base branch from graphite-base/37537 to master May 23, 2024 17:54
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from ea6f22e to 5b15fc5 Compare May 23, 2024 17:55
@stephane-airbyte stephane-airbyte merged commit b0ab148 into master May 23, 2024
27 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch May 23, 2024 18:01
@stephane-airbyte stephane-airbyte mentioned this pull request May 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisripa gisripa gisripa approved these changes

@edgao edgao edgao approved these changes

@akashkulk akashkulk Awaiting requested review from akashkulk

@postamar postamar Awaiting requested review from postamar

@rodireich rodireich Awaiting requested review from rodireich

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephane-airbyte @gisripa @edgao @octavia-squidington-iii