Fix primary key select #16937
Merged
Fix primary key select #16937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flicts with what we're trying to do
github-actions
bot
added
area/platform
|
I tested this with #16934 merged in and did not see any regression. |
matter-q
approved these changes
Sep 21, 2022
| }} | ||
| backspaceRemovesValue={false} | ||
| controlShouldRenderValue={false} | ||
| hideSelectedOptions={false} | ||
| isClearable={false} | ||
| menuIsOpen={isOpen} | ||
| // menuPosition={"fixed"} | ||
| menuShouldBlockScroll={false} |
There was a problem hiding this comment.
Yes, it will fix the issue, but on the other side, it could create a new bug with floating menu
There was a problem hiding this comment.
A later issue! 😂
teallarson
reviewed
Sep 21, 2022
teallarson
approved these changes
Sep 21, 2022
teallarson
approved these changes
Sep 21, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Scroll blocking adds a second "cover everything" dom element that conflicts with what we're trying to do * Remove commented code * Fixing error validation message
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Scroll blocking adds a second "cover everything" dom element that conflicts with what we're trying to do * Remove commented code * Fixing error validation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix primary key selection on replication view
Resolves https://github.com/airbytehq/oncall/issues/634
How
The DropDown component adds a complete-screen DOM element to prevent scrolling which conflicted with our "click outside to exit" DOM element. By telling the DropDown not to block scrolling it removes the conflict.
Playing with the z-index did not yield fruitful results.
🚨 User Impact 🚨
This affects dropdowns so there's always a chance for regression.
#16934 is in the same space so it will be important to test both throughly!