Fix request new connector button #16934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
|
I tested this with #16937 merged in and did not see any regression. |
teallarson
approved these changes
Sep 21, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Combine div's, set positive to relative * Type args * Fix theme reference
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Combine div's, set positive to relative * Type args * Fix theme reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Request New Connector button was not taking clicks. Likely due to the react-select upgrade.
Resolves https://github.com/airbytehq/oncall/issues/630
How
Setting
position: relative;let it be interacted with again.🚨 User Impact 🚨
This should not affect anything besides the problem
Scope Creep?
There are two changes outside the strict scope of the PR:
anygreyColro0which does not exist. I fixed it there and in one other place.