Add Contributors and Amendments sections #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcramps
approved these changes
Aug 31, 2018
bachand
approved these changes
Aug 31, 2018
|
|
||
| We encourage you to fork this guide and change the rules to fit your team’s style guide. Below, you may list some amendments to the style guide. This allows you to periodically update your style guide without having to deal with merge conflicts. | ||
|
|
||
| **[⬆ back to top](#table-of-contents)** |
There was a problem hiding this comment.
Let’s add a trailing new line
|
@fdiaz on mobile so can’t open a fix PR, but contributors links to the JavaScript graph. Missed this in my review :( |
|
Lol, nice catch! Doing another PR to fix. |
erichoracek
reviewed
Aug 31, 2018
|
|
||
| ## Contributors | ||
|
|
||
| - [View Contributors](https://github.com/airbnb/javascript/graphs/contributors) |
There was a problem hiding this comment.
This links to our JS repo
There was a problem hiding this comment.
Yup! #6 (comment) and #12
My bad! 😁
|
Fixed here #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Contributors and Amendments sections
Reasoning
Following our Javascript Style Guide we're adding a section for contributors and a section for amendments
Reviewers
cc @airbnb/swift-styleguide-maintainers