Fix Contributors link to point at Swift and not JS #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftal64
approved these changes
Aug 31, 2018
dfed
reviewed
Aug 31, 2018
| @@ -1421,7 +1421,7 @@ _You can enable the following settings in Xcode by running [this script](resourc | |||
|
|
|||
| ## Contributors | |||
|
|
|||
| - [View Contributors](https://github.com/airbnb/javascript/graphs/contributors) | |||
| - [View Contributors](https://github.com/airbnb/swift/graphs/contributors) | |||
There was a problem hiding this comment.
Use relative links!! I think you can do this as just /graphs/contributors
There was a problem hiding this comment.
Turns out I was wrong 😬
relative links seem to only work for code that is in the repo, which is highly unfortunate.
There was a problem hiding this comment.
Yup! Tried out and didn't work. I'll leave this as is 😉
fdiaz
force-pushed
the
fd/fix-contributors-link
branch
from
1c750ec to
9975c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Contributors link to point at Swift and not JS
Reasoning
Made a mistake in this PR by linking to our Javascript guide instead of our Swift guide 🤦♂️
Reviewers
cc @airbnb/swift-styleguide-maintainers