Skip to content

Commit

Permalink
🧪 Fix uploading coverage from GHA to Codecov
Browse files Browse the repository at this point in the history
The `codecov/codecov-action@v4` release of the official
GitHub Action for uploading coverage data to the
Codecov service turned out to be poorly tested alpha
quality software.
It has numerous bugs preventing it from successfully
sending the code coverage information over. So we
must postpone starting to use it until it's stable.

These patch downgrades it to v3 that remains functional
for the time being.

PR #941

Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
  • Loading branch information
Jamim and webknjaz authored Feb 2, 2024
1 parent bb2835b commit 19d0511
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ jobs:
coverage xml
shell: bash
- name: Send coverage data to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v3
with:
files: coverage.xml
flags: >-
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
run: |
make lint
- name: Send coverage data to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.codecov-token }}
files: >-
Expand Down
7 changes: 7 additions & 0 deletions CHANGES/941.contrib.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
`codecov-action <https://github.com/codecov/codecov-action>`_
has been temporarily downgraded to ``v3``
in the GitHub Actions CI/CD workflow definitions
in order to fix uploading coverage to
`Codecov <https://app.codecov.io/gh/aio-libs/multidict>`_.
See `this issue <https://github.com/codecov/codecov-action/issues/1252>`_
for more details.

1 comment on commit 19d0511

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed with codecov/codecov-cli#390.

Please sign in to comment.