fix: update user file search #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 81 81
Lines 2816 2817 +1
=======================================
+ Hits 2704 2705 +1
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thomasrockhu-codecov
requested review from
joseph-sentry and
giovanni-guidini
giovanni-guidini
approved these changes
Feb 27, 2024
webknjaz
referenced
this pull request
in aio-libs/multidict
Feb 28, 2024
The `codecov/codecov-action@v4` release of the official GitHub Action for uploading coverage data to the Codecov service turned out to be poorly tested alpha quality software. It has numerous bugs preventing it from successfully sending the code coverage information over. So we must postpone starting to use it until it's stable. These patch downgrades it to v3 that remains functional for the time being. PR #941 Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes codecov/feedback#84
This PR does 3 things
project_roottosearch_rootto make it more maintainable and understandableos.walk