Add a cache to must_be_empty_body #9174
Conversation
Nearly all the calls are going to be the same so we can cache the logic related issue #2779
bdraco
added
backport-3.10
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9174 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 107 107
Lines 34483 34485 +2
Branches 4093 4095 +2
=======================================
+ Hits 33901 33903 +2
Misses 411 411
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Personally, I don't think these are user-facing really, so all the recent PRs could probably be grouped to a single changenote about performance. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9190 🤖 @patchback |
(cherry picked from commit 98b363e)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9191 🤖 @patchback |
(cherry picked from commit 98b363e)
What do these changes do?
Nearly all the calls are going to be the same so we can cache the logic
I couldn't figure out how to avoid this call in most cases like #9172 so a cache made more sense.
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
related issue #2779
before
after
