Improve performance of starting web requests when content length is not set #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder the start logic to avoid the check to remove content length if its not present related issue #2779
bdraco
added
backport-3.10
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9172 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 107 107
Lines 34485 34496 +11
Branches 4095 4095
=======================================
+ Hits 33903 33916 +13
+ Misses 411 410 -1
+ Partials 171 170 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks like we are missing coverage for this case but it was not obvious before |
Dreamsorcerer
approved these changes
Sep 18, 2024
This was referenced Sep 18, 2024
bdraco
commented
Sep 18, 2024
bdraco
changed the title
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9192 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit b93ef57)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9193 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit b93ef57)
bdraco
added a commit
that referenced
this pull request
Sep 18, 2024
…b requests when content length is not set (#9192) Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
added a commit
that referenced
this pull request
Sep 18, 2024
…b requests when content length is not set (#9193) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Reorder the start logic to avoid the check to remove content length if its not present
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
related issue #2779
before
after
