-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused backwards compatibility code for old yarl versions #9083
Conversation
#9079 increased the yarl minimum version so we can remove these shims
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9083 +/- ##
==========================================
- Coverage 98.30% 98.30% -0.01%
==========================================
Files 107 107
Lines 34415 34403 -12
Branches 4080 4074 -6
==========================================
- Hits 33831 33819 -12
Misses 412 412
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply a6dd415 on top of patchback/backports/3.11/a6dd415a1401c82722aed12b86ab878e9afb017f/pr-9083 Backporting merged PR #9083 into master
🤖 @patchback |
(cherry picked from commit a6dd415)
We ended up having to bump yarl in 3.10 for path_safe anyways so we should backport this as well. |
I'll add the tag after the release is done to not tie up the CI |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply a6dd415 on top of patchback/backports/3.10/a6dd415a1401c82722aed12b86ab878e9afb017f/pr-9083 Backporting merged PR #9083 into master
🤖 @patchback |
(cherry picked from commit a6dd415)
…ty code for old yarl versions (#9289)
What do these changes do?
#9068 (comment)
Remove unused backwards compatibility code for old yarl versions
#9079 increased the yarl minimum version so we can remove these shims
Are there changes in behavior for the user?
no