Use URL.extend_query to add params in ClientRequest

[bdraco]

• needs yarl bumped before this can merge so we test both paths Bump yarl to 1.11.0 #9072

What do these changes do?

Use URL.extend_query to add params in ClientRequest

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

[Dreamsorcerer]

I'd be tempted to just move this to 3.11 and increase the minimum yarl version (or do this in 3.10 and remove the old path in 3.11), as these kind of checks tend to be forgotten about for years after they're useful. We can do the same for using the Query type.

[bdraco]

I will

• bump yarl on master/3.11/3.10 (not the requirement, only dep)
• merge
• backport this to 3.10 and 3.11 [PR #9068/841d00e backport][3.10] Use URL.extend_query to add params in ClientRequest #9077 [PR #9068/841d00e backport][3.11] Use URL.extend_query to add params in ClientRequest #9078
• merge Use Query typedef from yarl for params #8564
• and backport [PR #8564/b543677e backport][3.11] Use Query typedef from yarl for params #9081 [PR #8564/b543677e backport][3.10] Use Query typedef from yarl for params #9080
• do another PR to increment requirement of the minimum yarl version to 1.11.0 for master Bump yarl requirement to >=1.11.0 #9079
• back port 3.11 [PR #9079/7404afc backport][3.11] Bump yarl requirement to >=1.11.0 #9082
• than another one cleanup the back compat (as there are other places as well) for master Remove unused backwards compatibility code for old yarl versions #9083
• back port 3.11 [PR #9083/a6dd415 backport][3.11] Remove unused backwards compatibility code for old yarl versions #9085
• remove back compat code that is only in 3.11 [3.11] Remove unused backwards compatibility code in web_urldispatcher for old yarl versions #9084

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (7fb1631) to head (fbd50e7).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9068   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         107      107           
  Lines       34390    34397    +7     
  Branches     4075     4081    +6     
=======================================
+ Hits        33806    33813    +7     
  Misses        412      412           
  Partials      172      172           

Flag	Coverage Δ
CI-GHA	98.19% <100.00%> (+<0.01%)	⬆️
OS-Linux	97.86% <100.00%> (+<0.01%)	⬆️
OS-Windows	96.27% <100.00%> (+<0.01%)	⬆️
OS-macOS	97.53% <100.00%> (-0.01%)	⬇️
Py-3.10.11	97.63% <100.00%> (+<0.01%)	⬆️
Py-3.10.14	97.56% <100.00%> (+<0.01%)	⬆️
Py-3.11.9	97.79% <100.00%> (+<0.01%)	⬆️
Py-3.12.5	97.91% <100.00%> (+<0.01%)	⬆️
Py-3.9.13	97.52% <100.00%> (+<0.01%)	⬆️
Py-3.9.19	97.46% <100.00%> (+<0.01%)	⬆️
Py-pypy7.3.16	97.07% <100.00%> (+<0.01%)	⬆️
VM-macos	97.53% <100.00%> (-0.01%)	⬇️
VM-ubuntu	97.86% <100.00%> (+<0.01%)	⬆️
VM-windows	96.27% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[patchback]

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 841d00e on top of patchback/backports/3.10/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068

Backporting merged PR #9068 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.10/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068 upstream/3.10

4. Now, cherry-pick PR Use URL.extend_query to add params in ClientRequest #9068 contents into that branch:

   $ git cherry-pick -x 841d00eb3c5393fc6eccbfcd09114b14c74772d4

   If it'll yell at you with something like fatal: Commit 841d00eb3c5393fc6eccbfcd09114b14c74772d4 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 841d00eb3c5393fc6eccbfcd09114b14c74772d4

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Use URL.extend_query to add params in ClientRequest #9068 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.10/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 841d00e on top of patchback/backports/3.11/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068

Backporting merged PR #9068 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.11/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068 upstream/3.11

4. Now, cherry-pick PR Use URL.extend_query to add params in ClientRequest #9068 contents into that branch:

   $ git cherry-pick -x 841d00eb3c5393fc6eccbfcd09114b14c74772d4

   If it'll yell at you with something like fatal: Commit 841d00eb3c5393fc6eccbfcd09114b14c74772d4 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 841d00eb3c5393fc6eccbfcd09114b14c74772d4

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Use URL.extend_query to add params in ClientRequest #9068 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.11/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[bdraco]

Pretty significant drop on the profile 👍